Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: improve some tests of auto fix feature #6014

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

Tguisnet
Copy link
Contributor

@Tguisnet Tguisnet commented Dec 5, 2023

No description provided.

@Tguisnet Tguisnet requested a review from a team as a code owner December 5, 2023 18:30
@Tguisnet Tguisnet force-pushed the tgu/improve-tests-auto-fix branch from d5f25b7 to 9a0c4ae Compare December 5, 2023 18:36
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f4de8f) 26.56% compared to head (f7aaba2) 26.56%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6014      +/-   ##
============================================
- Coverage     26.56%   26.56%   -0.01%     
  Complexity     2122     2122              
============================================
  Files           931      931              
  Lines        122965   122965              
  Branches       2675     2675              
============================================
- Hits          32664    32663       -1     
- Misses        88716    88717       +1     
  Partials       1585     1585              
Flag Coverage Δ
core 78.98% <ø> (ø)
editoast 74.66% <ø> (-0.01%) ⬇️
front 9.33% <ø> (ø)
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner indeed, thanks !

editoast/src/views/infra/auto_fixes.rs Show resolved Hide resolved
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tguisnet Tguisnet force-pushed the tgu/improve-tests-auto-fix branch 4 times, most recently from 4f51788 to 790979e Compare December 11, 2023 13:26
@Tguisnet Tguisnet force-pushed the tgu/improve-tests-auto-fix branch from 790979e to f7aaba2 Compare December 11, 2023 13:52
@Tguisnet Tguisnet enabled auto-merge December 11, 2023 14:06
@Tguisnet Tguisnet added this pull request to the merge queue Dec 11, 2023
Merged via the queue into dev with commit 3ea1931 Dec 11, 2023
17 checks passed
@Tguisnet Tguisnet deleted the tgu/improve-tests-auto-fix branch December 11, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants