front: restore miniGET sync by storing scale domain #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5601 +/- ##
============================================
+ Coverage 27.72% 27.87% +0.15%
Complexity 2165 2165
============================================
Files 1003 1007 +4
Lines 126573 126912 +339
Branches 2580 2582 +2
============================================
+ Hits 35097 35382 +285
- Misses 89986 90038 +52
- Partials 1490 1492 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alexandredamiron
added
area:front
alexandredamiron
force-pushed
the
adn/syncMiniGET
branch
from
106396c to
0c052ec
Compare
SharglutDev
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Thank you for the PR. Left one comment.
Tested and it works when entering a scenario but if I delete the selected train in the timetable, the synchro with the timeline is lost.
It might work again when this issue will be fixed.
front/src/modules/simulationResult/components/TimeLine/TimeLine.tsx
Outdated
Show resolved
Hide resolved
Probably so I'll wait for it |
|
The fix is merged, you can rebase and test if it's working :) |
alexandredamiron
force-pushed
the
adn/syncMiniGET
branch
from
0c052ec to
7897fe4
Compare
It's working, could you make a last chek ? |
SharglutDev
previously approved these changes
Nov 27, 2023
clarani
requested changes
Nov 29, 2023
front/src/modules/simulationResult/components/SpaceTimeChart/withOSRDData.tsx
Outdated
Show resolved
Hide resolved
clarani
reviewed
Dec 5, 2023
front/src/applications/operationalStudies/views/SimulationResults.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/SimulationResults.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/SimulationResults.tsx
Outdated
Show resolved
Hide resolved
alexandredamiron
force-pushed
the
adn/syncMiniGET
branch
from
eb3bf2a to
3eec694
Compare
front:no use of chartXDomain front: no more sync by store front: no nice remove useless func def
clarani
force-pushed
the
adn/syncMiniGET
branch
from
3eec694 to
e8783b6
Compare
clarani
dismissed stale reviews from SharglutDev and themself
This PR needed a rebase and some adaptations, so the approve is not valid anymore
clarani
force-pushed
the
adn/syncMiniGET
branch
from
e8783b6 to
771581d
Compare
clarani
force-pushed
the
adn/syncMiniGET
branch
from
771581d to
312d0ff
Compare
SharglutDev
requested changes
Jan 23, 2024
front/src/modules/simulationResult/components/TimeLine/TimeLine.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/SpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/SimulationResults.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/SpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/SpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/SpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
SharglutDev
requested changes
Jan 23, 2024
front/src/modules/simulationResult/components/SpaceTimeChart/SpaceTimeChart.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will restore sunc between Timeline and GET in domain changes by sliders. Cannot pass D3Scale trhough Store, so it is the retrurn of chartXCGEV, in a readable manner (i hope)
Closes #5367