Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: decrease the electrification layer order priority to avoid masking path in map #10370

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Jan 13, 2025

Close #6546

The electrification layer could also be drawn even earlier in LAYER_GROUPS.TOPOGRAPHY, or smaller layer groups could be created to separate tracks, electrification and path.

Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
@Synar Synar requested a review from a team as a code owner January 13, 2025 18:23
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (650eca3) to head (615af02).
Report is 19 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10370      +/-   ##
==========================================
- Coverage   81.64%   81.62%   -0.02%     
==========================================
  Files        1066     1066              
  Lines      105687   105687              
  Branches      727      727              
==========================================
- Hits        86290    86270      -20     
- Misses      19356    19376      +20     
  Partials       41       41              
Flag Coverage Δ
editoast 73.61% <ø> (-0.07%) ⬇️
front 89.33% <100.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Caracol3 Caracol3 requested review from Math-R and Caracol3 January 14, 2025 09:30
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Synar Synar added this pull request to the merge queue Jan 14, 2025
Merged via the queue into dev with commit ddc52f5 Jan 14, 2025
27 checks passed
@Synar Synar deleted the ali/fix-electrification-layer-order-in-map branch January 14, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electrification layer covers the path found
4 participants