Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: fix maximum Python version #10342

Merged
merged 1 commit into from
Jan 13, 2025
Merged

python: fix maximum Python version #10342

merged 1 commit into from
Jan 13, 2025

Conversation

emersion
Copy link
Member

Python 3.12 doesn't work:

# poetry run pflake8 --config ./pyproject.toml
Traceback (most recent call last):
  File "/root/.cache/pypoetry/virtualenvs/railjson-generator--f9Ha3Rv-py3.12/bin/pflake8", line 5, in <module>
    from pflake8.__main__ import main
  File "/root/.cache/pypoetry/virtualenvs/railjson-generator--f9Ha3Rv-py3.12/lib/python3.12/site-packages/pflake8/__init__.py", line 55, in <module>
    class DivertingSafeConfigParser(ConfigParserTomlMixin, configparser.SafeConfigParser):
                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?

See this upstream bug report:
pydata/pandas-datareader#969

Our CI already checks out Python 3.11, so let's align our maximum version with what CI uses.

@emersion emersion requested a review from a team as a code owner January 13, 2025 14:00
@github-actions github-actions bot added the area:railjson Work on Proposed Unified Rail Assets Data Exchange Format label Jan 13, 2025
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable! 😄

Python 3.12 doesn't work:

    # poetry run pflake8 --config ./pyproject.toml
    Traceback (most recent call last):
      File "/root/.cache/pypoetry/virtualenvs/railjson-generator--f9Ha3Rv-py3.12/bin/pflake8", line 5, in <module>
        from pflake8.__main__ import main
      File "/root/.cache/pypoetry/virtualenvs/railjson-generator--f9Ha3Rv-py3.12/lib/python3.12/site-packages/pflake8/__init__.py", line 55, in <module>
        class DivertingSafeConfigParser(ConfigParserTomlMixin, configparser.SafeConfigParser):
                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?

See this upstream bug report:
pydata/pandas-datareader#969

Our CI already checks out Python 3.11, so let's align our maximum
version with what CI uses.

Signed-off-by: Simon Ser <contact@emersion.fr>
@emersion emersion force-pushed the emr/fix-py-max-version branch from 5ce21d3 to 6adc6d6 Compare January 13, 2025 14:59
@emersion emersion enabled auto-merge January 13, 2025 14:59
@emersion emersion added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@emersion emersion added this pull request to the merge queue Jan 13, 2025
Merged via the queue into dev with commit 102e1e3 Jan 13, 2025
27 checks passed
@emersion emersion deleted the emr/fix-py-max-version branch January 13, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:railjson Work on Proposed Unified Rail Assets Data Exchange Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants