python: fix missing flake8-formatter-junit-xml dependency #10341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:railjson
In CI we use the following command:
poetry run pflake8 --config ./pyproject.toml --output-file flake8.xml --format junit-xml
Unfortunately, when flake8 doesn't recognize a predefined format,
it silently interprets it as a format string. As a result the
output file flake8.xml contained a single line with the raw
string "junit-xml".
Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/fix-missing-flake8-junit-xml
branch
from
6e072df to
8ee0426
Compare
leovalais
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI we use the following command:
Unfortunately, when flake8 doesn't recognize a predefined format, it silently interprets it as a format string. As a result the output file flake8.xml contained a single line with the raw string "junit-xml".
Example: /~https://github.com/OpenRailAssociation/osrd/actions/runs/12713432631/job/35441321986?pr=10325#step:6:3