Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: provide a default value for ETCS brake parameters #10340

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

woshilapin
Copy link
Contributor

Without this default value, it's a breaking change and consumers of this repository will have to update their use of RollingStock class.

@woshilapin woshilapin requested a review from bougue-pe January 13, 2025 13:53
@woshilapin woshilapin requested a review from a team as a code owner January 13, 2025 13:53
@github-actions github-actions bot added the area:railjson Work on Proposed Unified Rail Assets Data Exchange Format label Jan 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (673dc44) to head (7da888c).
Report is 24 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10340      +/-   ##
==========================================
- Coverage   81.64%   81.63%   -0.02%     
==========================================
  Files        1066     1066              
  Lines      105687   105687              
  Branches      727      727              
==========================================
- Hits        86291    86280      -11     
- Misses      19355    19366      +11     
  Partials       41       41              
Flag Coverage Δ
editoast 73.64% <ø> (-0.04%) ⬇️
front 89.33% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thanks!

Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
@woshilapin woshilapin force-pushed the wsl/schema/default-etcs branch from 34cac07 to 7da888c Compare January 13, 2025 14:22
@woshilapin woshilapin added this pull request to the merge queue Jan 14, 2025
Merged via the queue into dev with commit cf771fa Jan 14, 2025
27 checks passed
@woshilapin woshilapin deleted the wsl/schema/default-etcs branch January 14, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:railjson Work on Proposed Unified Rail Assets Data Exchange Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants