Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix displayed op on manchette #10334

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Jan 13, 2025

Set the weight of the main PRs (origin, arrival and vias) to 100.
For vias added by hand from the map, they were previously set to “null”, now they're set to 100, so they're displayed on the manchette.

Tests :

  • add a waypoint using the functionality, see it displayed on the basic cuff and GEV
  • add a waypoint by clicking on the map, and see it displayed on the headline and GEV.
  • check PR weights console.log(operationalPoints.weight) and verify that passage PRs have a weight of 100

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 13, 2025
@Akctarus Akctarus self-assigned this Jan 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.79%. Comparing base (c4c4c58) to head (ec3d362).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...s/helpers/upsertMapWaypointsInOperationalPoints.ts 85.36% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10334      +/-   ##
==========================================
- Coverage   81.79%   81.79%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106543   106564      +21     
  Branches      727      732       +5     
==========================================
+ Hits        87147    87162      +15     
- Misses      19357    19363       +6     
  Partials       39       39              
Flag Coverage Δ
editoast 74.21% <ø> (+<0.01%) ⬆️
front 89.36% <86.66%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus marked this pull request as ready for review January 14, 2025 21:22
@Akctarus Akctarus requested a review from a team as a code owner January 14, 2025 21:22
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great ! Good job !
I just left one comment

@Akctarus Akctarus force-pushed the tmn/front/fix-weighted-OP branch from e08bc04 to a598a58 Compare January 16, 2025 14:00
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akctarus Akctarus force-pushed the tmn/front/fix-weighted-OP branch 2 times, most recently from bf9d526 to 3f15094 Compare January 20, 2025 10:17
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
@Akctarus Akctarus force-pushed the tmn/front/fix-weighted-OP branch from 5faac45 to ec3d362 Compare January 20, 2025 13:17
@Akctarus Akctarus enabled auto-merge January 20, 2025 13:17
@Akctarus Akctarus added this pull request to the merge queue Jan 20, 2025
Merged via the queue into dev with commit 8affe7b Jan 20, 2025
27 checks passed
@Akctarus Akctarus deleted the tmn/front/fix-weighted-OP branch January 20, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants