-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix displayed op on manchette #10334
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10334 +/- ##
==========================================
- Coverage 81.79% 81.79% -0.01%
==========================================
Files 1073 1073
Lines 106543 106564 +21
Branches 727 732 +5
==========================================
+ Hits 87147 87162 +15
- Misses 19357 19363 +6
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChartContainer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great ! Good job !
I just left one comment
front/src/applications/operationalStudies/helpers/upsertMapWaypointsInOperationalPoints.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/helpers/upsertMapWaypointsInOperationalPoints.ts
Outdated
Show resolved
Hide resolved
.../modules/simulationResult/components/SpaceTimeChart/useGetProjectedTrainOperationalPoints.ts
Outdated
Show resolved
Hide resolved
.../modules/simulationResult/components/SpaceTimeChart/useGetProjectedTrainOperationalPoints.ts
Show resolved
Hide resolved
e08bc04
to
a598a58
Compare
front/src/applications/operationalStudies/helpers/upsertMapWaypointsInOperationalPoints.ts
Show resolved
Hide resolved
.../modules/simulationResult/components/SpaceTimeChart/useGetProjectedTrainOperationalPoints.ts
Outdated
Show resolved
Hide resolved
.../modules/simulationResult/components/SpaceTimeChart/useGetProjectedTrainOperationalPoints.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bf9d526
to
3f15094
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
Signed-off-by: Theo Macron <theo.macron0315@gmail.com>
5faac45
to
ec3d362
Compare
Set the weight of the main PRs (origin, arrival and vias) to 100.
For vias added by hand from the map, they were previously set to “null”, now they're set to 100, so they're displayed on the manchette.
Tests :