Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table headers to start with lowercase letters for consistency #10308

Merged

Conversation

achrafmohye
Copy link
Contributor

@achrafmohye achrafmohye commented Jan 9, 2025

This is a quick fix for this comment in #10000

@achrafmohye achrafmohye requested a review from a team as a code owner January 9, 2025 14:21
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.61%. Comparing base (38f11bd) to head (164a69c).
Report is 10 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10308      +/-   ##
==========================================
- Coverage   81.63%   81.61%   -0.02%     
==========================================
  Files        1063     1063              
  Lines      105426   105426              
  Branches      722      722              
==========================================
- Hits        86063    86045      -18     
- Misses      19322    19340      +18     
  Partials       41       41              
Flag Coverage Δ
editoast 73.64% <ø> (-0.06%) ⬇️
front 89.33% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achrafmohye achrafmohye force-pushed the ame/fix-stdcm-report-sheet-table-headers-to-lowercase branch 2 times, most recently from 4453931 to e91be4a Compare January 9, 2025 15:17
Signed-off-by: Achraf Mohyeddine <a.mohyeddine@gmail.com>
@achrafmohye achrafmohye force-pushed the ame/fix-stdcm-report-sheet-table-headers-to-lowercase branch from e91be4a to 164a69c Compare January 9, 2025 15:38
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@achrafmohye achrafmohye added this pull request to the merge queue Jan 13, 2025
Merged via the queue into dev with commit c7b8c33 Jan 13, 2025
27 checks passed
@achrafmohye achrafmohye deleted the ame/fix-stdcm-report-sheet-table-headers-to-lowercase branch January 13, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants