-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change name for interne deployment #10302
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10302 +/- ##
=======================================
Coverage 81.61% 81.61%
=======================================
Files 1067 1067
Lines 105535 105624 +89
Branches 727 727
=======================================
+ Hits 86128 86205 +77
- Misses 19366 19378 +12
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR !
In my understanding of the front (which might get a bit rusty over time) I think we should reference directly only the files that are present in the code base (the default logo) and switch if the override file exists on the server and defines the fields on the json.
front/src/applications/stdcm/components/StdcmResults/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks !
9e3dc3d
to
23fa75a
Compare
front/src/applications/stdcm/components/StdcmResults/SimulationReportStyleSheet.ts
Outdated
Show resolved
Hide resolved
bf5c79a
to
3e97922
Compare
3e97922
to
e83a2ad
Compare
ce6f849
to
6936ddb
Compare
Tested on internal deployments, works properly. LGTM. |
0284f29
to
32cf3d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
32cf3d3
to
bf11090
Compare
- change logo stdcm when using application internally Signed-off-by: Uriel-Sautron <uriel.sautron@gmail.com> - add lmr logo in stdcm simulation report sheet when using the application internally - create hook useLogo - use useLogo in app - remove logo.ts - add customized name - change hook useLoge to useDeploymentSetting test: change name stdcm pdf - with the modifications on the names in internal deployment the name of the pdf changed from STDCM to Stdcm
bf11090
to
c380d4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several occurrences of lmr
which is not (yet) used for the open source part. Ideally, we should only use stdcm
for consistency.
close #10281
For internal deployment we need to display the LMR and Horizon logos.
For test:
overrides
at the front rootoverrides.json