core: stdcm: set a min speed for engineering allowance check #10289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to consider that we can add any amount of time if the train can basically stop, but this was too optimistic Signed-off-by: Eloi Charpentier <eloi.charpentier.42@gmail.com>
eckter
force-pushed
the
ech/fix-engineering-check
branch
from
79b87f4 to
aeeae9d
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10289 +/- ##
==========================================
+ Coverage 81.49% 81.51% +0.01%
==========================================
Files 1058 1059 +1
Lines 104270 104459 +189
Branches 722 722
==========================================
+ Hits 84973 85146 +173
- Misses 19256 19272 +16
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to consider that we can add any amount of time if the train can basically stop, but this was too optimistic
Fix #9023 (at least some cases, I'll run the fuzzer to look for any other bug)