front: stdcm - new query should clear the hour field #10286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10286 +/- ##
==========================================
- Coverage 81.63% 81.62% -0.01%
==========================================
Files 1063 1063
Lines 105438 105435 -3
Branches 722 722
==========================================
- Hits 86071 86059 -12
- Misses 19326 19335 +9
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This component is gonna change very soon here. But you're probably right for the value thing :) |
Related to #9533 TimePicker component should not have a `value` properety, it only needs `hours`, `minutes` & `seconds`. See OpenRailAssociation/osrd-ui#807 for more informations Signed-off-by: Benoit Simard <contact@bsimard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9533
TimePicker component should not have a
valueproperty, it only needshours,minutes&seconds.Giving a
valueproperty to the component lead to some unwanted behaviors.See OpenRailAssociation/osrd-ui#807 for more information