Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix nge update after importing or deleting multiple trains #10285

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

RomainValls
Copy link
Contributor

close #10028

@RomainValls RomainValls requested a review from a team as a code owner January 8, 2025 11:07
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.39%. Comparing base (cae4d30) to head (a67ef86).
Report is 93 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10285      +/-   ##
==========================================
- Coverage   81.49%   81.39%   -0.10%     
==========================================
  Files        1058     1027      -31     
  Lines      104270   102741    -1529     
  Branches      722      722              
==========================================
- Hits        84973    83628    -1345     
+ Misses      19256    19072     -184     
  Partials       41       41              
Flag Coverage Δ
editoast 73.71% <ø> (-0.03%) ⬇️
front 89.21% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator ?
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: romainvalls <romain.valls95@gmail.com>
@RomainValls RomainValls force-pushed the rvs/front-fix-nge-updates branch from 5c2a460 to a67ef86 Compare January 8, 2025 12:47
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fixup, LGTM tested.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@RomainValls RomainValls added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@RomainValls RomainValls added this pull request to the merge queue Jan 15, 2025
Merged via the queue into dev with commit 271dbed Jan 15, 2025
27 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-nge-updates branch January 15, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro mode : multiple deletion or importation from the train list does not update the graph
4 participants