Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix "rolling stock" spelling in English translations #10284

Merged
merged 1 commit into from
Jan 8, 2025
Merged

front: fix "rolling stock" spelling in English translations #10284

merged 1 commit into from
Jan 8, 2025

Conversation

emersion
Copy link
Member

@emersion emersion commented Jan 8, 2025

"Rollingstock" is not an English word.

@emersion emersion requested a review from a team as a code owner January 8, 2025 10:21
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 8, 2025
SharglutDev
SharglutDev approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In rollingstock.json, there are some use of rollingstock as well. Should we fix them ?

Caracol3
Caracol3 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emersion
front: fix "rolling stock" spelling in English translations
abf4611 
"Rollingstock" is not an English word.

Signed-off-by: Simon Ser <contact@emersion.fr>
@emersion
Copy link
Member Author

emersion commented Jan 8, 2025

In rollingstock.json, there are some use of rollingstock as well. Should we fix them ?

Good catch, fixed!

@emersion emersion enabled auto-merge January 8, 2025 11:09
@emersion emersion added this pull request to the merge queue Jan 8, 2025
Merged via the queue into dev with commit 995c248 Jan 8, 2025
27 checks passed
@emersion emersion deleted the emr/en-rs branch January 8, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caracol3 Caracol3 Caracol3 approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersion @SharglutDev @Caracol3