Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: add weight field to operational points path_properties #10275

Merged
merged 1 commit into from
Jan 9, 2025
Merged

editoast: add weight field to operational points path_properties #10275

merged 1 commit into from
Jan 9, 2025

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Jan 7, 2025

No description provided.

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 7, 2025
@Akctarus Akctarus self-assigned this Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64%. Comparing base (384dcea) to head (858af72).
Report is 36 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10275      +/-   ##
==========================================
+ Coverage   81.53%   81.64%   +0.10%     
==========================================
  Files        1059     1063       +4     
  Lines      104491   105520    +1029     
  Branches      722      722              
==========================================
+ Hits        85198    86151     +953     
- Misses      19252    19328      +76     
  Partials       41       41
Flag Coverage Δ
editoast 73.62% <ø> (-0.13%) ⬇️
front 89.37% <100.00%> (+0.12%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/update-OP-weight branch from 2af9401 to 933bbeb Compare January 8, 2025 09:57
@github-actions github-actions bot added area:core Work on Core Service area:editoast Work on Editoast Service labels Jan 8, 2025
@younesschrifi younesschrifi force-pushed the tmn/front/update-OP-weight branch 6 times, most recently from a1931e4 to e569e73 Compare January 8, 2025 15:36
@Akctarus Akctarus marked this pull request as ready for review January 8, 2025 15:46
@Akctarus Akctarus requested review from a team as code owners January 8, 2025 15:46
@Akctarus Akctarus requested review from Erashin, leovalais and eckter and removed request for Erashin January 8, 2025 15:46
leovalais
leovalais approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

editoast/src/core/path_properties.rs Outdated Show resolved Hide resolved
Erashin
Erashin approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core lgtm :)

@younesschrifi younesschrifi force-pushed the tmn/front/update-OP-weight branch from e569e73 to 3c94f18 Compare January 8, 2025 17:31
@younesschrifi younesschrifi removed the request for review from eckter January 8, 2025 22:09
SharglutDev
SharglutDev approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm except the console.log :)

front/src/applications/operationalStudies/views/SimulationResults.tsx Outdated Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the tmn/front/update-OP-weight branch from 3c94f18 to 1267f18 Compare January 9, 2025 09:07
@Akctarus Akctarus changed the title front: charts: adapt origin, destination and vias weight editoast: add weight to operational points Jan 9, 2025
@Akctarus Akctarus force-pushed the tmn/front/update-OP-weight branch 2 times, most recently from e0b99bc to ee65204 Compare January 9, 2025 09:25
@Akctarus Akctarus removed the area:front Work on Standard OSRD Interface modules label Jan 9, 2025
@younesschrifi younesschrifi force-pushed the tmn/front/update-OP-weight branch from ee65204 to aacec9a Compare January 9, 2025 09:31
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 9, 2025
@younesschrifi younesschrifi force-pushed the tmn/front/update-OP-weight branch 2 times, most recently from a0fef0d to e3e61f7 Compare January 9, 2025 09:47
@Akctarus Akctarus changed the title editoast: add weight to operational points editoast: add weight field to operational points path_properties Jan 9, 2025
@younesschrifi younesschrifi force-pushed the tmn/front/update-OP-weight branch from e3e61f7 to 0d212f4 Compare January 9, 2025 09:54
@younesschrifi younesschrifi force-pushed the tmn/front/update-OP-weight branch 2 times, most recently from d492199 to deb4f59 Compare January 9, 2025 10:21
@Khoyo
Copy link
Contributor

Khoyo commented Jan 9, 2025

You need to ./gradlew spotlessApply in core/

@younesschrifi younesschrifi force-pushed the tmn/front/update-OP-weight branch from deb4f59 to d30040f Compare January 9, 2025 10:52
@younesschrifi
core: editoast: add weight field to operational points path property
858af72 
Signed-off-by: Youness CHRIFI ALAOUI <youness.chrifi@gmail.com>
@younesschrifi younesschrifi force-pushed the tmn/front/update-OP-weight branch from d30040f to 858af72 Compare January 9, 2025 11:13
@younesschrifi younesschrifi added this pull request to the merge queue Jan 9, 2025
Merged via the queue into dev with commit cd9d8be Jan 9, 2025
27 checks passed
@younesschrifi younesschrifi deleted the tmn/front/update-OP-weight branch January 9, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesschrifi younesschrifi younesschrifi left review comments

@SharglutDev SharglutDev SharglutDev approved these changes

@Erashin Erashin Erashin approved these changes

@leovalais leovalais leovalais approved these changes

Assignees

@younesschrifi younesschrifi

@Akctarus Akctarus

Labels
area:core Work on Core Service area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Akctarus @codecov-commenter @Khoyo @leovalais @younesschrifi @Erashin @SharglutDev