Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: center text on stdcm error #10272

Merged
merged 1 commit into from
Jan 7, 2025
Merged

front: center text on stdcm error #10272

merged 1 commit into from
Jan 7, 2025

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Jan 7, 2025

fix #10135 for the text alignment

image

@sim51 sim51 requested a review from a team as a code owner January 7, 2025 15:39
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.47%. Comparing base (a4190de) to head (86446e3).
Report is 5 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10272      +/-   ##
==========================================
- Coverage   81.48%   81.47%   -0.02%     
==========================================
  Files        1058     1058              
  Lines      104270   104270              
  Branches      722      722              
==========================================
- Hits        84969    84954      -15     
- Misses      19260    19275      +15     
  Partials       41       41              
Flag Coverage Δ
editoast 73.68% <ø> (-0.05%) ⬇️
front 89.21% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, you can close the comment after fixing it :)

fix #10135

Signed-off-by: Benoit Simard <contact@bsimard.com>
@sim51 sim51 added this pull request to the merge queue Jan 7, 2025
Merged via the queue into dev with commit cae4d30 Jan 7, 2025
27 checks passed
@sim51 sim51 deleted the bsi/issue-10135 branch January 7, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lmr: Information message under error message is not centered
3 participants