Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display rs name instead of rs reference in StdcmReportSheet #10224

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 3, 2025

closes #10152

@clarani clarani requested a review from a team as a code owner January 3, 2025 08:51
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (2d1a142) to head (18a71da).
Report is 18 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10224      +/-   ##
==========================================
+ Coverage   81.42%   81.43%   +0.01%     
==========================================
  Files        1057     1058       +1     
  Lines      104204   104241      +37     
  Branches      720      724       +4     
==========================================
+ Hits        84849    84890      +41     
+ Misses      19313    19309       -4     
  Partials       42       42              
Flag Coverage Δ
editoast 73.60% <ø> (+0.03%) ⬆️
front 89.17% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/10152-fix-rs-name-on-stdcm-report-sheet branch from 7340ba3 to 18a71da Compare January 3, 2025 08:54
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@clarani clarani enabled auto-merge January 3, 2025 10:32
@clarani clarani requested a review from SharglutDev January 3, 2025 10:32
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@clarani clarani added this pull request to the merge queue Jan 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 3, 2025
@clarani clarani added this pull request to the merge queue Jan 3, 2025
Merged via the queue into dev with commit 62953a3 Jan 3, 2025
27 checks passed
@clarani clarani deleted the cni/10152-fix-rs-name-on-stdcm-report-sheet branch January 3, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LMR : The name of the rolling stock in the simulation report is not correct
4 participants