Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: drop ViaStopDurationSelector #10195

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 24, 2024

Not used anymore since the end of TS V2 migration and the new STDCM view page

@clarani clarani requested a review from a team as a code owner December 24, 2024 16:12
@clarani clarani self-assigned this Dec 24, 2024
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.90%. Comparing base (41e05a4) to head (39b3a08).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10195      +/-   ##
==========================================
- Coverage   79.94%   79.90%   -0.05%     
==========================================
  Files        1057     1056       -1     
  Lines      106302   106192     -110     
  Branches      724      720       -4     
==========================================
- Hits        84982    84851     -131     
- Misses      21278    21299      +21     
  Partials       42       42              
Flag Coverage Δ
editoast 73.86% <ø> (-0.07%) ⬇️
front 89.18% <100.00%> (-0.02%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested 👍

Not used anymore since the end of TS V2 migration and the new STDCM view page

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/clean-via-stop-duration-selector branch from 7919b9b to 39b3a08 Compare December 30, 2024 08:35
@clarani clarani enabled auto-merge December 30, 2024 10:03
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@clarani clarani added this pull request to the merge queue Dec 30, 2024
Merged via the queue into dev with commit ec0c1a4 Dec 30, 2024
27 checks passed
@clarani clarani deleted the cni/clean-via-stop-duration-selector branch December 30, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants