Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: create train settings reducer #10194

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 24, 2024

Move some actions from the commonConf to operationalStudiesConf since it is only used in the operational studies application

To merge after #10202

@clarani clarani requested a review from a team as a code owner December 24, 2024 16:11
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 24, 2024
@clarani clarani self-assigned this Dec 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 99.31507% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (9c5ee0d) to head (0937c60).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...ockSelector/useStoreDataForRollingStockSelector.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10194      +/-   ##
==========================================
- Coverage   81.44%   81.43%   -0.02%     
==========================================
  Files        1057     1058       +1     
  Lines      104212   104251      +39     
  Branches      720      724       +4     
==========================================
+ Hits        84875    84894      +19     
- Misses      19295    19315      +20     
  Partials       42       42              
Flag Coverage Δ
editoast 73.59% <ø> (-0.05%) ⬇️
front 89.17% <99.31%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me thanks for the refacto :)

@clarani clarani marked this pull request as draft December 30, 2024 10:26
@clarani clarani force-pushed the cni/create-train-settings-reducer branch from 79276e5 to 21a93d2 Compare December 30, 2024 15:14
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/create-train-settings-reducer branch from 21a93d2 to 0937c60 Compare January 2, 2025 08:48
@clarani clarani marked this pull request as ready for review January 2, 2025 08:49
@clarani clarani requested a review from SharglutDev January 2, 2025 09:11
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this clean up. Left some comments (you probably already thought of most of them for another PR 🙂)

@clarani
Copy link
Contributor Author

clarani commented Jan 2, 2025

@SharglutDev I added a comment about your remarks in this issue, if you want to have a look 😉

@clarani clarani requested a review from SharglutDev January 2, 2025 14:33
@clarani clarani enabled auto-merge January 2, 2025 15:15
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, you can close the last remaining comments after reading them :)

@clarani clarani added this pull request to the merge queue Jan 3, 2025
Merged via the queue into dev with commit de25aca Jan 3, 2025
27 checks passed
@clarani clarani deleted the cni/create-train-settings-reducer branch January 3, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants