-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: create train settings reducer #10194
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10194 +/- ##
==========================================
- Coverage 81.44% 81.43% -0.02%
==========================================
Files 1057 1058 +1
Lines 104212 104251 +39
Branches 720 724 +4
==========================================
+ Hits 84875 84894 +19
- Misses 19295 19315 +20
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me thanks for the refacto :)
79276e5
to
21a93d2
Compare
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
21a93d2
to
0937c60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this clean up. Left some comments (you probably already thought of most of them for another PR 🙂)
front/src/reducers/osrdconf/operationalStudiesConf/trainSettingsReducer.ts
Show resolved
Hide resolved
@SharglutDev I added a comment about your remarks in this issue, if you want to have a look 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, you can close the last remaining comments after reading them :)
Move some actions from the commonConf to operationalStudiesConf since it is only used in the operational studies application
To merge after #10202