Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operational point search performance issues #10172

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Dec 23, 2024

fixes #10138

@leovalais leovalais requested a review from a team as a code owner December 23, 2024 17:44
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Dec 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.93%. Comparing base (3bc6d02) to head (3165f73).
Report is 74 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/editoast_derive/src/search.rs 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10172      +/-   ##
==========================================
- Coverage   79.94%   79.93%   -0.01%     
==========================================
  Files        1057     1057              
  Lines      106302   106311       +9     
  Branches      724      724              
==========================================
- Hits        84980    84978       -2     
- Misses      21280    21291      +11     
  Partials       42       42              
Flag Coverage Δ
editoast 73.89% <90.00%> (-0.03%) ⬇️
front 89.19% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also fixes the performance issue of the operational point search.

Signed-off-by: Leo Valais <leo.valais97@gmail.com>
@leovalais leovalais force-pushed the lva/search-select-distinct branch from c739668 to 3165f73 Compare December 24, 2024 12:57
@leovalais leovalais enabled auto-merge December 26, 2024 15:24
@leovalais leovalais self-assigned this Jan 6, 2025
@leovalais leovalais added this pull request to the merge queue Jan 7, 2025
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into dev with commit ef6e28e Jan 7, 2025
27 checks passed
@leovalais leovalais deleted the lva/search-select-distinct branch January 7, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search endpoint is taking forever
3 participants