front: move allWaypoints to ManageTrainScheduleContextType #10169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
commented
Dec 23, 2024
front/src/applications/operationalStudies/hooks/useManageTrainScheduleContext.tsx
Outdated
Show resolved
Hide resolved
clarani
approved these changes
Dec 24, 2024
front/src/applications/operationalStudies/hooks/useManageTrainScheduleContext.tsx
Outdated
Show resolved
Hide resolved
theocrsb
approved these changes
Jan 2, 2025
This value should be updated every time pathSteps or suggestedOperationalPoints change. Instead of manually updating it when touching these two values, memoize it. Signed-off-by: Simon Ser <contact@emersion.fr>
This list doesn't only contain waypoints, it also contains all suggested OPs. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/usememo-all-waypoints
branch
from
3505153 to
6cdf1ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value should be updated every time pathSteps or suggestedOperationalPoints change. Instead of manually updating it when touching these two values, memoize it.