editoast: bump osm4routing to avoid two compilations of protobuf #10160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristramg
force-pushed
the
bump_osm4routing
branch
from
50753c4 to
a2dc9e6
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10160 +/- ##
=======================================
Coverage 79.96% 79.96%
=======================================
Files 1057 1057
Lines 106394 106367 -27
Branches 725 725
=======================================
- Hits 85074 85054 -20
+ Misses 21278 21271 -7
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leovalais
approved these changes
Dec 20, 2024
Signed-off-by: Tristram Gräbener <tristram+git@tristramg.eu>
Tristramg
force-pushed
the
bump_osm4routing
branch
from
a2dc9e6 to
6ee9f57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a small compilation time improvement, as there is no longer two protobuf versions to compile
The total compilation time from scratch goes down from 186 seconds to 174. It’s a oneshot benchmark, so not very reliable, but there aren’t much downsides to this bump
Here is a screenshot of the situation before obtained by calling
cargo build --timings