Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: improve import view #10139

Merged
merged 5 commits into from
Jan 2, 2025
Merged

front: improve import view #10139

merged 5 commits into from
Jan 2, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 19, 2024 •
edited
Loading

close #8115

You can ask me some files to test the PR

@clarani clarani requested a review from a team as a code owner December 19, 2024 14:42
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 19, 2024
@clarani clarani requested review from Yohh and SharglutDev December 19, 2024 14:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (1e79fc2) to head (3f4ed07).
Report is 6 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10139      +/-   ##
==========================================
- Coverage   81.43%   81.42%   -0.02%     
==========================================
  Files        1057     1057              
  Lines      104212   104207       -5     
  Branches      720      720              
==========================================
- Hits        84870    84846      -24     
- Misses      19300    19319      +19     
  Partials       42       42
Flag Coverage Δ
editoast 73.55% <ø> (-0.07%) ⬇️
front 89.18% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev mentioned this pull request Dec 20, 2024
Merged
SharglutDev
SharglutDev reviewed Dec 20, 2024
View reviewed changes
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/handleParseFiles.ts Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/handleParseFiles.ts Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/handleParseFiles.ts Outdated Show resolved Hide resolved
...t/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsList.tsx Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/handleParseFiles.ts Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/handleParseFiles.ts Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/handleParseFiles.ts Show resolved Hide resolved
@clarani clarani requested a review from SharglutDev January 2, 2025 08:54
SharglutDev
SharglutDev approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! You can fix and resolve the last comments when done :)

front/public/locales/fr/operationalStudies/importTrainSchedule.json Show resolved Hide resolved
clarani added 5 commits January 2, 2025 11:15
@clarani
front: support any type of files in importTrainSchedules
58feda3 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: display error if imported json is empty
bce1af3 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: improve import error message
2bf094c 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: clean and improve import translations
64fade6 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: add validation when importing trains from json file
3f4ed07 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/8115-improve-import-view branch from 9a50863 to 3f4ed07 Compare January 2, 2025 10:22
@clarani clarani enabled auto-merge January 2, 2025 10:26
@clarani clarani added this pull request to the merge queue Jan 2, 2025
Merged via the queue into dev with commit 04792ff Jan 2, 2025
27 checks passed
@clarani clarani deleted the cni/8115-improve-import-view branch January 2, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@Yohh Yohh Awaiting requested review from Yohh

@flomonster flomonster Awaiting requested review from flomonster

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird behavior and error messages importing train schedule files
3 participants
@clarani @codecov-commenter @SharglutDev