Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add tracing for ping operations #10129

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

woshilapin
Copy link
Contributor

It seems that our healtcheck needs a relatively long time (#10026) but we're missing information about what could take time. Let's first add a way to measure it and see what we can do with it later.

Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
@woshilapin woshilapin requested a review from a team as a code owner December 19, 2024 10:17
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Dec 19, 2024
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (4e1462b) to head (a49627f).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/core/mq_client.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10129   +/-   ##
=======================================
  Coverage   79.83%   79.83%           
=======================================
  Files        1054     1054           
  Lines      105536   105520   -16     
  Branches      726      726           
=======================================
- Hits        84250    84238   -12     
+ Misses      21244    21240    -4     
  Partials       42       42           
Flag Coverage Δ
editoast 73.74% <66.66%> (-0.01%) ⬇️
front 89.14% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin woshilapin added this pull request to the merge queue Dec 19, 2024
Merged via the queue into dev with commit 020e8fe Dec 19, 2024
27 checks passed
@woshilapin woshilapin deleted the wsl/editoast/ping-tracing branch December 19, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants