core: stdcm: limit the loop where we look for possible delays #10126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eckter
force-pushed
the
ech/limit-delays-loop
branch
2 times, most recently
from
a1e4640 to
dacfa1e
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10126 +/- ##
==========================================
+ Coverage 79.81% 79.82% +0.01%
==========================================
Files 1052 1054 +2
Lines 105444 105547 +103
Branches 727 726 -1
==========================================
+ Hits 84155 84252 +97
- Misses 21247 21253 +6
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
force-pushed
the
ech/limit-delays-loop
branch
from
dacfa1e to
b53af39
Compare
eckter
force-pushed
the
ech/limit-delays-loop
branch
from
b53af39 to
8a3622d
Compare
We would keep looking for different "openings" even very far in the future. This limits both conflict detection calls and the early steps of edge building. Signed-off-by: Eloi Charpentier <eloi.charpentier.42@gmail.com>
eckter
force-pushed
the
ech/limit-delays-loop
branch
from
8a3622d to
4820803
Compare
Khoyo
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would keep looking for different "openings" even very far in the future. This limits both conflict detection calls and the early steps of edge building.
The speedup is actually really good (roughly dividing the computation time by 2).
In the previous version, we would do something like that: we look for "openings" infinitely far in the future, and it's only when checking for conflicts and engineering allowances that we would discard them. In this case (and in fact in most case), there's only one "opening" available without clear conflicts.