Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix stop time hours display + fix stop time center #10125

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

EthanPERRUZZA
Copy link
Contributor

@EthanPERRUZZA EthanPERRUZZA commented Dec 18, 2024

  • Stop time didn't display the minutes component
  • Stop time wasn't centered in the div

fix #9503
fix #10029

@EthanPERRUZZA EthanPERRUZZA self-assigned this Dec 18, 2024
@EthanPERRUZZA EthanPERRUZZA requested a review from a team as a code owner December 18, 2024 13:38
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 18, 2024
@EthanPERRUZZA EthanPERRUZZA force-pushed the eth/stop-time branch 2 times, most recently from 4e3290a to ea3cfd3 Compare December 18, 2024 13:40
@EthanPERRUZZA
Copy link
Contributor Author

#9503

@EthanPERRUZZA
Copy link
Contributor Author

#10029

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.82%. Comparing base (ef69c8d) to head (ea61967).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10125      +/-   ##
==========================================
- Coverage   79.83%   79.82%   -0.01%     
==========================================
  Files        1054     1054              
  Lines      105538   105530       -8     
  Branches      727      726       -1     
==========================================
- Hits        84251    84236      -15     
- Misses      21245    21252       +7     
  Partials       42       42              
Flag Coverage Δ
editoast 73.72% <ø> (-0.03%) ⬇️
front 89.14% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

* Stop time didn't display the minutes component
* Stop time wasn't centered in the div

Signed-off-by: Ethan Perruzza <ethan.perruzza@gmail.com>
@EthanPERRUZZA EthanPERRUZZA added this pull request to the merge queue Dec 18, 2024
Merged via the queue into dev with commit ea19025 Dec 18, 2024
27 checks passed
@EthanPERRUZZA EthanPERRUZZA deleted the eth/stop-time branch December 18, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
3 participants