Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: use 'const' syntax from 'tracing' for opentelemetry semantic convention #10110

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

woshilapin
Copy link
Contributor

We can actually use variables as keys in span metadata, as long as they're const. See the documentation.

…c convention

Signed-off-by: Jean SIMARD <woshilapin@tuziwo.info>
@woshilapin woshilapin requested a review from a team as a code owner December 17, 2024 13:04
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.80%. Comparing base (844c6b3) to head (5f8e62c).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
.../src/db_connection_pool/tracing_instrumentation.rs 62.50% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10110      +/-   ##
==========================================
- Coverage   79.81%   79.80%   -0.02%     
==========================================
  Files        1053     1053              
  Lines      105483   105483              
  Branches      727      727              
==========================================
- Hits        84196    84182      -14     
- Misses      21245    21259      +14     
  Partials       42       42              
Flag Coverage Δ
editoast 73.70% <62.50%> (-0.05%) ⬇️
front 89.13% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@woshilapin woshilapin added this pull request to the merge queue Dec 17, 2024
Merged via the queue into dev with commit 5af6621 Dec 17, 2024
27 checks passed
@woshilapin woshilapin deleted the wsl/editoast/const-semantic-conventions branch December 17, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants