-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix typo in classname #10096
front: fix typo in classname #10096
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10096 +/- ##
==========================================
- Coverage 79.83% 79.81% -0.02%
==========================================
Files 1054 1054
Lines 105547 105547
Branches 726 726
==========================================
- Hits 84262 84241 -21
- Misses 21243 21264 +21
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a detail, but perhaps we could call the import-invalid-stepnb
class to match the parent.
But otherwise the PR works fine :)
Yes I think it's easier to read like this, we should rather change the parent class :) |
Signed-off-by: romainvalls <romain.valls95@gmail.com>
13478df
to
84cea88
Compare
close #9594
I've let a typo in the previous feature fixing it.