Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix typo in classname #10096

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

RomainValls
Copy link
Contributor

close #9594

I've let a typo in the previous feature fixing it.

@RomainValls RomainValls requested a review from a team as a code owner December 16, 2024 17:36
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (6580cfe) to head (84cea88).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10096      +/-   ##
==========================================
- Coverage   79.83%   79.81%   -0.02%     
==========================================
  Files        1054     1054              
  Lines      105547   105547              
  Branches      726      726              
==========================================
- Hits        84262    84241      -21     
- Misses      21243    21264      +21     
  Partials       42       42              
Flag Coverage Δ
editoast 73.68% <ø> (-0.07%) ⬇️
front 89.14% <100.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a detail, but perhaps we could call the import-invalid-stepnb class to match the parent.
But otherwise the PR works fine :)

@RomainValls
Copy link
Contributor Author

This is a detail, but perhaps we could call the import-invalid-stepnb class to match the parent. But otherwise the PR works fine :)

I agree ! But I remember @clarani requested this change in the last pull request i sent. What do you think @clarani ?

@clarani
Copy link
Contributor

clarani commented Dec 17, 2024

Yes I think it's easier to read like this, we should rather change the parent class :)

Signed-off-by: romainvalls <romain.valls95@gmail.com>
@Caracol3 Caracol3 force-pushed the rvs/front-fix-invalid-step-nb-color-in-import-files branch from 13478df to 84cea88 Compare December 19, 2024 11:22
@Caracol3 Caracol3 added this pull request to the merge queue Dec 19, 2024
Merged via the queue into dev with commit 465d3d1 Dec 19, 2024
27 checks passed
@Caracol3 Caracol3 deleted the rvs/front-fix-invalid-step-nb-color-in-import-files branch December 19, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viriato import with 0 OP matched
6 participants