Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix manchette scroll overflow #10090

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Dec 16, 2024

Fix manchette scroll

@Wadjetz Wadjetz self-assigned this Dec 16, 2024
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 16, 2024
@Wadjetz Wadjetz requested review from SharglutDev and Yohh December 16, 2024 13:53
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.80%. Comparing base (5d127e0) to head (7be3cd6).
Report is 19 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10090      +/-   ##
==========================================
- Coverage   79.81%   79.80%   -0.02%     
==========================================
  Files        1052     1052              
  Lines      105444   105446       +2     
  Branches      727      727              
==========================================
- Hits        84155    84146       -9     
- Misses      21247    21258      +11     
  Partials       42       42              
Flag Coverage Δ
editoast 73.70% <ø> (-0.04%) ⬇️
front 89.13% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz marked this pull request as ready for review December 16, 2024 14:38
@Wadjetz Wadjetz requested a review from a team as a code owner December 16, 2024 14:38
Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
@Wadjetz Wadjetz force-pushed the ebe/front/manchette-fix-scroll branch from 7d9937f to 7be3cd6 Compare December 17, 2024 09:22
@Wadjetz Wadjetz requested a review from theocrsb December 17, 2024 09:22
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank you for the fix !

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@Wadjetz Wadjetz added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@Wadjetz Wadjetz added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@Wadjetz Wadjetz added this pull request to the merge queue Dec 18, 2024
Merged via the queue into dev with commit 855aaad Dec 18, 2024
27 checks passed
@Wadjetz Wadjetz deleted the ebe/front/manchette-fix-scroll branch December 18, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants