front: stop hardcoding navbar height in scenario #10089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/scenario-no-hardcoded-height
branch
from
ee9b7c6 to
e439a7a
Compare
SharglutDev
approved these changes
Dec 18, 2024
front/src/applications/operationalStudies/components/Scenario/ScenarioContent.tsx
Outdated
Show resolved
Hide resolved
Drop --navbar-height. Replace it with full-height containers, and simplify the overall structure. Fixes a blank margin below the conflict list on smaller screens. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/scenario-no-hardcoded-height
branch
from
e439a7a to
af55e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
--navbar-height. Replace it with full-height containers, and simplify the overall structure.Fixes a blank margin below the conflict list on smaller screens.
This PR is better reviewed with the "Hide whitespace" option enabled in the GitHub diff view settings.
Depends on #9869