front: update typescript-eslint #10084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10084 +/- ##
==========================================
- Coverage 81.44% 81.43% -0.01%
==========================================
Files 1058 1058
Lines 104243 104275 +32
Branches 724 723 -1
==========================================
+ Hits 84900 84916 +16
- Misses 19301 19317 +16
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
force-pushed
the
pfn/front/update-typescript-eslint
branch
2 times, most recently
from
af3a3de to
c8fef03
Compare
anisometropie
requested changes
Dec 16, 2024
This was referenced Dec 16, 2024
emersion
reviewed
Dec 17, 2024
emersion
reviewed
Dec 17, 2024
emersion
reviewed
Dec 17, 2024
anisometropie
approved these changes
Dec 18, 2024
SharglutDev
force-pushed
the
pfn/front/update-typescript-eslint
branch
from
c15388f to
3d7a744
Compare
emersion
approved these changes
Jan 3, 2025
- Remove the ban-types related to React.FC in .eslintrc as ban-types is not supported anymore and as we don't use RC in the appr anymore anyway. - Remove some unneeded asserts - Error in a catch now need to be handled, use the error in setFailure to display notifications to the user Signed-off-by: SharglutDev <p.filimon75@gmail.com>
SharglutDev
force-pushed
the
pfn/front/update-typescript-eslint
branch
from
3d7a744 to
e80e3a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not supported anymore and as we don't use RC in the appr anymore anyway.
to display notifications to the user