Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: deactivate marker check for e2e tests #10078

Merged
merged 1 commit into from
Dec 13, 2024
Merged

front: deactivate marker check for e2e tests #10078

merged 1 commit into from
Dec 13, 2024

Conversation

Maymanaf
Copy link
Contributor

@Maymanaf Maymanaf commented Dec 13, 2024 •
edited
Loading

Deactivate marker check for e2e tests until osm server is up again

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 13, 2024
@Maymanaf Maymanaf marked this pull request as ready for review December 13, 2024 13:26
@Maymanaf Maymanaf requested a review from a team as a code owner December 13, 2024 13:26
@Maymanaf Maymanaf force-pushed the aba/e2e-deactivate-marker-check branch from bfee8b2 to 688df5b Compare December 13, 2024 13:33
emersion
emersion approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: instead of commenting, if (false) could be used to reduce the diff and avoid TypeScript errors due to unused variables. But I'm fine with commenting as well.

@Maymanaf Maymanaf force-pushed the aba/e2e-deactivate-marker-check branch from 688df5b to a930087 Compare December 13, 2024 13:46
clarani
clarani approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maymanaf
front: deactivate marker check for e2e tests
ce7d851 
Signed-off-by: maymanaf <med.aymen.naf@gmail.com>
@Maymanaf Maymanaf force-pushed the aba/e2e-deactivate-marker-check branch from a930087 to ce7d851 Compare December 13, 2024 14:11
@Maymanaf Maymanaf enabled auto-merge December 13, 2024 14:27
@Maymanaf Maymanaf added this pull request to the merge queue Dec 13, 2024
Merged via the queue into dev with commit c669033 Dec 13, 2024
27 checks passed
@Maymanaf Maymanaf deleted the aba/e2e-deactivate-marker-check branch December 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@Yohh Yohh Yohh approved these changes

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Maymanaf @emersion @Yohh @clarani