-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: lmr prefill consist max speed from tag #10039
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10039 +/- ##
=======================================
Coverage 79.81% 79.81%
=======================================
Files 1052 1053 +1
Lines 105444 105482 +38
Branches 727 727
=======================================
+ Hits 84155 84195 +40
+ Misses 21247 21245 -2
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c845eb5
to
0b51459
Compare
Shouldn't the speed be reset when -none- is clicked? |
front/src/applications/stdcm/utils/maxSpeedFromSpeedLimitByTag.ts
Outdated
Show resolved
Hide resolved
@theocrsb It resets the value if neither a traction engine nor towed rolling stock is selected. If one of these values is selected, it uses the selected value. |
Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
bcbef50
to
55139f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job ! Don't forget to fixup your last commit :)
fix #10016
Prefill consist max speed from speed limit tag