Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: lmr prefill consist max speed from tag #10039

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Dec 12, 2024

fix #10016

Prefill consist max speed from speed limit tag

@Wadjetz Wadjetz self-assigned this Dec 12, 2024
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (5d127e0) to head (55139f9).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10039   +/-   ##
=======================================
  Coverage   79.81%   79.81%           
=======================================
  Files        1052     1053    +1     
  Lines      105444   105482   +38     
  Branches      727      727           
=======================================
+ Hits        84155    84195   +40     
+ Misses      21247    21245    -2     
  Partials       42       42           
Flag Coverage Δ
editoast 73.74% <ø> (+<0.01%) ⬆️
front 89.13% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/front/lrm-max-speed-from-tag branch 3 times, most recently from c845eb5 to 0b51459 Compare December 12, 2024 17:11
@Wadjetz Wadjetz marked this pull request as ready for review December 13, 2024 08:33
@Wadjetz Wadjetz requested a review from a team as a code owner December 13, 2024 08:33
@theocrsb
Copy link
Contributor

Shouldn't the speed be reset when -none- is clicked?

@Wadjetz
Copy link
Member Author

Wadjetz commented Dec 16, 2024

Shouldn't the speed be reset when -none- is clicked?

@theocrsb It resets the value if neither a traction engine nor towed rolling stock is selected. If one of these values is selected, it uses the selected value.

Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
@Wadjetz Wadjetz force-pushed the ebe/front/lrm-max-speed-from-tag branch from bcbef50 to 55139f9 Compare December 17, 2024 09:16
@Wadjetz Wadjetz requested a review from SharglutDev December 17, 2024 09:40
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! Don't forget to fixup your last commit :)

@Wadjetz Wadjetz added this pull request to the merge queue Dec 17, 2024
Merged via the queue into dev with commit 3f5afb8 Dec 17, 2024
28 checks passed
@Wadjetz Wadjetz deleted the ebe/front/lrm-max-speed-from-tag branch December 17, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link the max speed of the consist to the composition code in STDCM
4 participants