-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: display simulation results only if a train is selected or get data is ready #10035
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10035 +/- ##
==========================================
- Coverage 79.83% 79.81% -0.02%
==========================================
Files 1054 1054
Lines 105547 105545 -2
Branches 726 726
==========================================
- Hits 84261 84246 -15
- Misses 21244 21257 +13
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, just one question :)
front/src/applications/operationalStudies/views/SimulationResults.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested, but I agree with @SharglutDev :)
front/src/applications/operationalStudies/views/SimulationResults.tsx
Outdated
Show resolved
Hide resolved
9bca048
to
f100fb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I delete the selected train (which is not the projected one), it seems there is no new one selected (or probably it goes on an invalid one) and we keep seeing the map/output table loader.
Enregistrement.de.l.ecran.2024-12-17.a.09.07.26.mov
You're right, I think it's fixed like this, what do you think ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the last change, everything looks great !
…data is ready Signed-off-by: Clara Ni <clara.ni@outlook.fr>
654ca2a
to
5fbb2ac
Compare
closes #10031