Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display simulation results only if a train is selected or get data is ready #10035

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 12, 2024

closes #10031

@clarani clarani requested a review from a team as a code owner December 12, 2024 14:49
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 12, 2024
@clarani clarani enabled auto-merge December 12, 2024 14:50
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.81%. Comparing base (465d3d1) to head (5fbb2ac).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10035      +/-   ##
==========================================
- Coverage   79.83%   79.81%   -0.02%     
==========================================
  Files        1054     1054              
  Lines      105547   105545       -2     
  Branches      726      726              
==========================================
- Hits        84261    84246      -15     
- Misses      21244    21257      +13     
  Partials       42       42              
Flag Coverage Δ
editoast 73.70% <ø> (-0.05%) ⬇️
front 89.14% <100.00%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, just one question :)

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested, but I agree with @SharglutDev :)

@clarani clarani force-pushed the cni/10031-hide-scenario-result-if-empty branch from 9bca048 to f100fb5 Compare December 16, 2024 16:18
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I delete the selected train (which is not the projected one), it seems there is no new one selected (or probably it goes on an invalid one) and we keep seeing the map/output table loader.

Enregistrement.de.l.ecran.2024-12-17.a.09.07.26.mov

@clarani
Copy link
Contributor Author

clarani commented Dec 17, 2024

You're right, I think it's fixed like this, what do you think ?

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the last change, everything looks great !

…data is ready

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/10031-hide-scenario-result-if-empty branch from 654ca2a to 5fbb2ac Compare December 19, 2024 13:39
@clarani clarani added this pull request to the merge queue Dec 19, 2024
Merged via the queue into dev with commit 07e13ab Dec 19, 2024
27 checks passed
@clarani clarani deleted the cni/10031-hide-scenario-result-if-empty branch December 19, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My scenario tries to load some output table though i have no trains in it
4 participants