Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add towed rolling stock e2e test #10025

Merged
merged 1 commit into from
Dec 23, 2024
Merged

front: add towed rolling stock e2e test #10025

merged 1 commit into from
Dec 23, 2024

Conversation

Maymanaf
Copy link
Contributor

@Maymanaf Maymanaf commented Dec 12, 2024 •
edited
Loading

Closes #9743

This PR:

  • Keeps only the required fake train for e2e tests in freightRollingStocks.ts.
  • Adjusts the method responsible for filling the consist fields to ensure that selecting a rolling stock or towed rolling stock correctly pre-fills the tonnage, length, and maximum speed fields.
  • Creates two simulations: one without outputs and another with outputs using a towed rolling stock, verifying the table outputs accordingly.
  • Replaces all console usage with the appropriate logger type.
  • Fixes typos.

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 12, 2024
@Maymanaf Maymanaf force-pushed the aba/e2e-towed-rolling-stock branch 3 times, most recently from 9307f9d to 8db9cf7 Compare December 13, 2024 16:17
@Maymanaf Maymanaf marked this pull request as ready for review December 13, 2024 16:18
@Maymanaf Maymanaf requested review from a team as code owners December 13, 2024 16:18
@Maymanaf Maymanaf force-pushed the aba/e2e-towed-rolling-stock branch from 8db9cf7 to f82b943 Compare December 16, 2024 13:46
@Maymanaf Maymanaf mentioned this pull request Dec 17, 2024
Merged
Yohh
Yohh reviewed Dec 18, 2024
View reviewed changes
front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved
front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved
front/tests/utils/api-setup.ts Outdated Show resolved Hide resolved
SharglutDev
SharglutDev reviewed Dec 18, 2024
View reviewed changes
front/tests/utils/api-setup.ts Outdated Show resolved Hide resolved
front/tests/utils/api-setup.ts Outdated Show resolved Hide resolved
front/tests/utils/api-setup.ts Show resolved Hide resolved
front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved
front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved
front/tests/pages/stdcm-page-model.ts Outdated Show resolved Hide resolved
@Maymanaf Maymanaf force-pushed the aba/e2e-towed-rolling-stock branch 2 times, most recently from 1db1fb2 to 9d79c18 Compare December 20, 2024 09:02
SharglutDev
SharglutDev approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! (still confused about my weird test fail for the help button in local)

Yohh
Yohh approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Maymanaf
front: add towed rolling stock e2e test
bc81106 
Signed-off-by: maymanaf <med.aymen.naf@gmail.com>
@Maymanaf Maymanaf force-pushed the aba/e2e-towed-rolling-stock branch from 4b05fbb to bc81106 Compare December 23, 2024 08:15
@Maymanaf Maymanaf enabled auto-merge December 23, 2024 08:16
@Maymanaf Maymanaf added this pull request to the merge queue Dec 23, 2024
Merged via the queue into dev with commit 07ef33a Dec 23, 2024
27 checks passed
@Maymanaf Maymanaf deleted the aba/e2e-towed-rolling-stock branch December 23, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@Yohh Yohh Yohh approved these changes

@Wadjetz Wadjetz Awaiting requested review from Wadjetz

@emersion emersion Awaiting requested review from emersion

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: LMR towed rolling stock e2e test
4 participants
@Maymanaf @emersion @Yohh @SharglutDev