Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up: Fix accents support in x-remote-user-name #10013

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

leovalais
Copy link
Contributor

Signed-off-by: Leo Valais <leo.valais97@gmail.com>
@leovalais leovalais requested a review from a team as a code owner December 10, 2024 15:59
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Dec 10, 2024
@leovalais leovalais requested a review from woshilapin December 10, 2024 16:00
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (f354aff) to head (ac741f6).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/mod.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10013      +/-   ##
==========================================
- Coverage   80.11%   80.10%   -0.02%     
==========================================
  Files        1048     1048              
  Lines      105250   105250              
  Branches      756      756              
==========================================
- Hits        84326    84307      -19     
- Misses      20883    20902      +19     
  Partials       41       41              
Flag Coverage Δ
editoast 74.20% <0.00%> (-0.07%) ⬇️
front 89.36% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leovalais leovalais added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@leovalais leovalais added this pull request to the merge queue Dec 10, 2024
Merged via the queue into dev with commit 9a10a58 Dec 10, 2024
27 checks passed
@leovalais leovalais deleted the lva/fix-accents branch December 10, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants