github: only group patch upgrades #10002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:front
The idea behind minor-and-patch was to group all uninteresting upgrades together. Indeed, with SemVer, patch and minor upgrades are not supposed to include API breaks, and grouping these together should be a good idea in theory as explained in the GitHub docs [1]. However, in practice this doesn't seem to work well. First, some packages are at version 0.x.y, and minor upgrades often contain breaking changes. Unfortunately there's no way to ask dependabot to not group these unstable dependencies. Another issue is that some minor upgrades do contain some breaking changes (e.g. typescript). Fix these issues by only grouping patch updates, which shoudl still keep the number of PRs to a reasonable number and not include any breaking upgrade. While at it, move the group to the end of the list so that it's only used if none of the other groups match the package which need updating. Indeed, dependabot picks the first group which matches the package [2]. [1]: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/customizing-dependency-updates#grouping-dependabot-updates-into-one-pull-request [2]: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/dependabot-only-group-patch
branch
from
bcdb5fb to
53a3389
Compare
github-actions
bot
removed
the
area:front
Yohh
approved these changes
Dec 12, 2024
Khoyo
approved these changes
Dec 12, 2024
SharglutDev
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind minor-and-patch was to group all uninteresting upgrades together. Indeed, with SemVer, patch and minor upgrades are not supposed to include API breaks, and grouping these together should be a good idea in theory as explained in the GitHub docs.
However, in practice this doesn't seem to work well. First, some packages are at version 0.x.y, and minor upgrades often contain breaking changes. Unfortunately there's no way to ask dependabot to not group these unstable dependencies. Another issue is that some minor upgrades do contain some breaking changes (e.g. typescript).
Fix these issues by only grouping patch updates, which shoudl still keep the number of PRs to a reasonable number and not include any breaking upgrade.
While at it, move the group to the end of the list so that it's only used if none of the other groups match the package which need updating. Indeed, dependabot picks the first group which matches the package.