-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and enhance simulation report sheet #10001
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10001 +/- ##
========================================
Coverage 81.52% 81.53%
========================================
Files 1059 1059
Lines 104457 104594 +137
Branches 722 722
========================================
+ Hits 85162 85280 +118
- Misses 19254 19273 +19
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c95d87e
to
95d9784
Compare
1bb87f2
to
47d2bbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, ty for this clean, just left few comments:
Tolerance could be set a little higher
The data seems to be shifted to the right of the column headings, so I think there's an extra margin somewhere. If you fix this problem, you'll also have to watch out for lines with stops, which are displayed in a different way from the others
front/src/applications/stdcm/components/StdcmResults/StdcmResults.tsx
Outdated
Show resolved
Hide resolved
47d2bbc
to
a5c1dad
Compare
205ed74
to
236f1d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
front/src/applications/stdcm/components/StdcmResults/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmResults/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmResults/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmResults/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
f2a58b9
to
105da8c
Compare
105da8c
to
8b801a7
Compare
25a91e3
to
ed241ee
Compare
front/src/applications/stdcm/components/StdcmResults/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmResults/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmResults/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcm/components/StdcmResults/SimulationReportSheet.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Achraf Mohyeddine <a.mohyeddine@gmail.com>
ed241ee
to
0edbc00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Closes #10000