-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui-core: add build instructions to readme file #88
Conversation
I struggled a lot today to build the project. There may be other commands that are better. Is there something that should be added or removed? I could not resolve the problems below with this library. What am I doing something wrong? I tried to install the package as specified on the npm page, but I had no luck: https://www.npmjs.com/package/@osrd-project/ui-icons |
It seems like this PR touches more than just the README - it also includes some To sum things up, IMHO |
5464062
to
2f49615
Compare
d9b1d95
to
ce305ca
Compare
@turnerian2004 that's a good point, basically we run the project with many changes are work-in-progress by @jacomyal , and a different process will be set very soon, but I think it's a good start! |
I'll get back later this week. I want to do a little reading up, if that's okay. |
ce305ca
to
c6eb629
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !! ✅
This README really needed this improvement 🙏
Issue #89