Use ROLLUP_WATCH instead of NODE_ENV #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to enable the livereload plugin when running in watch mode. We don't want to enable the livereload plugin when building, because that causes the build to hang forever. NODE_ENV is the wrong tool for the job here: it can be set to "development" even when running `npm run build`, for instance if the user has set it globally (on a dev machine). In general, NODE_ENV is just supposed to indicate whether a Node.js app is running in production - nothing else. Instead, use the ROLLUP_WATCH env var: it's set by rollup specifically when started in watch mode. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to enable the livereload plugin when running in watch mode. We don't want to enable the livereload plugin when building, because that causes the build to hang forever.
NODE_ENV is the wrong tool for the job here: it can be set to "development" even when running
npm run build, for instance if the user has set it globally (on a dev machine). In general, NODE_ENV is just supposed to indicate whether a Node.js app is running in production - nothing else.Instead, use the ROLLUP_WATCH env var: it's set by rollup specifically when started in watch mode.