ui-speedspacechart: use specific d3 sub-packages #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting it from @types/d3 by chance. Since we use chroma-js directly, let's add an explicit dependency. Signed-off-by: Simon Ser <contact@emersion.fr>
`'' || '00'` always evaluates to `'00'`. Signed-off-by: Simon Ser <contact@emersion.fr>
Instead of importing all of d3, only import the two sub-packages that we actually need: d3-selection and d3-zoom. This removes 28 dependencies. Signed-off-by: Simon Ser <contact@emersion.fr>
SharglutDev
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Instead of importing all of d3, only import the two sub-packages
that we actually need: d3-selection and d3-zoom.
This removes 28 unused d3 sub-packages and all of their dependencies.