Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ame ui-core time-picker #64

Merged
merged 1 commit into from
May 17, 2024
Merged

ame ui-core time-picker #64

merged 1 commit into from
May 17, 2024

Conversation

achrafmohye
Copy link
Contributor

Implements time-picker

@achrafmohye achrafmohye requested a review from kmer2016 May 16, 2024 08:25
@achrafmohye achrafmohye force-pushed the ame/ui-core/time-picker branch 3 times, most recently from 91f7b8d to 95d85b1 Compare May 17, 2024 15:07
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Refactor modal position and add useOutsideClick hook
@achrafmohye achrafmohye force-pushed the ame/ui-core/time-picker branch from 95d85b1 to 5825d99 Compare May 17, 2024 15:25
@achrafmohye achrafmohye merged commit 5218f06 into dev May 17, 2024
1 check passed
@achrafmohye achrafmohye deleted the ame/ui-core/time-picker branch May 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants