Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add date picker #57

Merged
merged 1 commit into from
Jul 19, 2024
Merged

core: add date picker #57

merged 1 commit into from
Jul 19, 2024

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented May 7, 2024

No description provided.

@achrafmohye achrafmohye force-pushed the cnh/ui-core/datePicker branch from 5f9ed89 to 548ed75 Compare May 31, 2024 16:18
@achrafmohye achrafmohye marked this pull request as ready for review May 31, 2024 16:18
@achrafmohye achrafmohye force-pushed the cnh/ui-core/datePicker branch from 548ed75 to 155a59f Compare May 31, 2024 16:28
@kmer2016 kmer2016 requested review from clarani and Math-R June 14, 2024 11:49
@kmer2016 kmer2016 force-pushed the cnh/ui-core/datePicker branch from 155a59f to fd54b20 Compare June 19, 2024 18:54
@clarani clarani changed the title Cnh/UI core/date picker Add date picker Jun 20, 2024
@clarani clarani changed the title Add date picker core: add date picker Jun 20, 2024
clarani
clarani requested changes Jun 24, 2024
View reviewed changes
ui-core/src/components/hooks/useModalPosition.tsx Show resolved Hide resolved
ui-core/src/components/inputs/PasswordInput.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/index.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/useDatePicker.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/useCalendarPicker.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/CalendarPicker.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/useDatePicker.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/CalendarPicker.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/CalendarPicker.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/useCalendarPicker.tsx Outdated Show resolved Hide resolved
clarani
clarani requested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I still can't give a date or a calendarSlot from the parent component.
Can you please update the stories to display a date by default ? With that, we will be sure that the datePicker works on initialization

ui-core/src/components/inputs/datePicker/DatePicker.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/DatePicker.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/useCalendarPicker.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/useCalendarPicker.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/useDatePicker.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/useDatePicker.ts Outdated Show resolved Hide resolved
@kmer2016 kmer2016 force-pushed the cnh/ui-core/datePicker branch 2 times, most recently from c8275c9 to 5c7b424 Compare July 5, 2024 19:35
clarani
clarani requested changes Jul 9, 2024
View reviewed changes
ui-core/src/index.ts Outdated Show resolved Hide resolved
ui-core/src/styles/animations.css Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/useDatePicker.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/utils.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/utils.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/__tests__/useCalendar.spec.ts Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/__tests__/useCalendar.spec.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/__tests__/useCalendarPicker.spec.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/__tests__/useCalendarPicker.spec.ts Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/__tests__/utils.spec.ts Outdated Show resolved Hide resolved
@kmer2016 kmer2016 requested a review from a team as a code owner July 10, 2024 13:30
@kmer2016 kmer2016 force-pushed the cnh/ui-core/datePicker branch 3 times, most recently from 02b802e to 267ecce Compare July 18, 2024 13:56
clarani
clarani approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

ui-core/src/components/inputs/datePicker/__tests__/useCalendar.spec.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/__tests__/useCalendar.spec.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/CalendarPicker.tsx Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/useCalendarPicker.ts Outdated Show resolved Hide resolved
ui-core/src/components/inputs/datePicker/Calendar.tsx Outdated Show resolved Hide resolved
@kmer2016 kmer2016 force-pushed the cnh/ui-core/datePicker branch from b2f5841 to 0a6d979 Compare July 19, 2024 16:04
@kmer2016 kmer2016 force-pushed the cnh/ui-core/datePicker branch from 0a6d979 to 1c1ea97 Compare July 19, 2024 16:22
@kmer2016 kmer2016 added this pull request to the merge queue Jul 19, 2024
Merged via the queue into dev with commit a212b42 Jul 19, 2024
3 checks passed
@kmer2016 kmer2016 deleted the cnh/ui-core/datePicker branch July 19, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@Math-R Math-R Awaiting requested review from Math-R

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmer2016 @clarani