Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-icons: fix gauge and signal icons for color #276

Merged
merged 1 commit into from
Jul 29, 2024
Merged

ui-icons: fix gauge and signal icons for color #276

merged 1 commit into from
Jul 29, 2024

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Jul 29, 2024

Actually gauge & signal icon doesn't support color changed.
It is due to the SVG that defined the filled color, so it can't be overridden.

@sim51 sim51 requested a review from a team as a code owner July 29, 2024 10:25
@sim51 sim51 changed the title ui-icons: fix gauge icons for color ui-icons: fix gauge and signal icons for color Jul 29, 2024
@sim51 sim51 enabled auto-merge July 29, 2024 11:52
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@sim51 sim51 added this pull request to the merge queue Jul 29, 2024
Merged via the queue into dev with commit b184caa Jul 29, 2024
3 checks passed
@sim51 sim51 deleted the bsi/icon-gauge branch July 29, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants