ui-speedspacechart: fix display issues when the GEV is integrated in OSRD #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yohh
force-pushed
the
yoh/ui-speedspacechart-fix-display-issues-for-integration
branch
from
693b92c to
2f21632
Compare
Yohh
force-pushed
the
yoh/ui-speedspacechart-fix-display-issues-for-integration
branch
from
1d85754 to
da0574d
Compare
SharglutDev
requested changes
Jul 24, 2024
ui-speedspacechart/src/components/layers/FrontInteractivityLayer.tsx
Outdated
Show resolved
Hide resolved
…OSRD - add setHeight props in SpeedSpaceChart, set it with dynamicHeight - adapt the story in .tsx to use a useState() hook - remove mt-2 useless tailwind rule for front-interractivity-layer - calculate the settings panel height by using the SpeedSpaceChart height - disable speedLimits and temporarySpeedLimits checkboxes - add missing type: 'non_electrified' in ElectrifictationValues
Yohh
force-pushed
the
yoh/ui-speedspacechart-fix-display-issues-for-integration
branch
from
56c6779 to
2aad9d1
Compare
Yohh
deleted the
yoh/ui-speedspacechart-fix-display-issues-for-integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #253