No error reporting for template saving #1790
Comments
dg0yt
added a commit
that referenced
this issue
Dec 2, 2020
Before this change, template data saving was done while saving template XML configuration. This worked only for the default file format, and it delayed finishing the writing of the map file until all modified templates were saved. This behaviour meant increasing the risk of losing changes to the map, due to crash or forceful termination (out-of-memory, or Android). In Exporter::doExport(), it is now easy to catch errors from saving template data and add messages the to the list of warnings. Resolves GH-1790 (No error reporting from template saving). Resolves GH-1791 (Template data saved only for default file format).
dg0yt
added a commit
that referenced
this issue
Dec 2, 2020
Before this change, template data saving was done while saving template XML configuration. This worked only for the default file format, and it delayed finishing the writing of the map file until all modified templates were saved. This behaviour meant increasing the risk of losing changes to the map, due to crash or forceful termination (out-of-memory, or Android). In Exporter::doExport(), it is now easy to catch errors from saving template data and add messages the to the list of warnings. Resolves GH-1790 (No error reporting from template saving). Resolves GH-1791 (Template data saved only for default file format).
dg0yt
added a commit
that referenced
this issue
Dec 2, 2020
Before this change, template data saving was done while saving template XML configuration. This worked only for the default file format, and it delayed finishing the writing of the map file until all modified templates were saved. This behaviour meant increasing the risk of losing changes to the map, due to crash or forceful termination (out-of-memory, or Android). In Exporter::doExport(), it is now easy to catch errors from saving template data and add messages the to the list of warnings. Resolves GH-1790 (No error reporting from template saving). Resolves GH-1791 (Template data saved only for default file format).
dg0yt
added a commit
that referenced
this issue
Dec 3, 2020
Before this change, template data saving was done while saving template XML configuration. This worked only for the default file format, and it delayed finishing the writing of the map file until all modified templates were saved. This behaviour meant increasing the risk of losing changes to the map, due to crash or forceful termination (out-of-memory, or Android). In Exporter::doExport(), it is now easy to catch errors from saving template data and add messages the to the list of warnings. Resolves GH-1790 (No error reporting from template saving). Resolves GH-1791 (Template data saved only for default file format).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Actual behaviour
When saving a template file (scribbling, GPX) fails,
Expected behaviour
The error should be reported.
The dirty state must be maintained.
Configuration
Mapper Version: v0.9.4
The text was updated successfully, but these errors were encountered: