Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan: added DOCblocks to most templates 🚀 #4468

Merged
merged 13 commits into from
Jan 14, 2025
Merged

PHPStan: added DOCblocks to most templates 🚀 #4468

merged 13 commits into from
Jan 14, 2025

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 11, 2025 •
edited
Loading

Description (*)

[OK] Baseline generated with 2337 errors.

Massive phpstan update. Mostly DOCblock changes ... check commits.

Reduce baseline from +6k errors.

  • minor doc fixes for Zend_Db_Exp, Zend_Date, Zend_Filter_Interface
  • validate renderer-blocks (Varien_Data_Form_Element_Renderer_Interface)
  • added DOCblocks to nearly every template (!!!)
  • ignore all template w/o reference found (later review)

@sreichel sreichel changed the title PHPStan: added DOCblock to templates PHPStan: added DOCblock to most templates 🚀 Jan 11, 2025
@sreichel sreichel changed the title PHPStan: added DOCblock to most templates 🚀 PHPStan: added DOCblocks to most templates 🚀 Jan 11, 2025
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template Component: Reports Relates to Mage_Reports Component: Checkout Relates to Mage_Checkout Component: Sales Relates to Mage_Sales Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Template : rwd Relates to rwd template Template : base Relates to base template Component: Adminhtml Relates to Mage_Adminhtml Component: Page Relates to Mage_Page labels Jan 11, 2025
@github-actions github-actions bot added Component: Api PageRelates to Mage_Api Component: Captcha Relates to Mage_Captcha Component: Tag Relates to Mage_Tag Component: CatalogRule Relates to Mage_CatalogRule Component: Wishlist Relates to Mage_Wishlist Component: Widget Relates to Mage_Widget Component: Weee Relates to Mage_Weee Component: Tax Relates to Mage_Tax Component: Shipping Relates to Mage_Shipping Component: Rule Relates to Mage_Rule Component: Review Relates to Mage_Review Component: Rating Relates to Mage_Rating Component: Payment Relates to Mage_Payment Component: Giftmessage Relates to Mage_Giftmessage Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle Component: Api2 Relates to Mage_Api2 Component: ImportExport Relates to Mage_ImportExport Component: CatalogSearch Relates to Mage_CatalogSearch shell Relates to shell scripts Component: Centinel Relates to Mage_Centinel Template : install Relates to install template Component: Rss Relates to Mage_Rss Component: Paygate Relates to Mage_Paygate labels Jan 11, 2025
@sreichel sreichel merged commit 45368ab into OpenMage:main Jan 14, 2025
18 checks passed
@sreichel sreichel deleted the phpstan-101 branch January 14, 2025 15:43
fballiano added a commit to MahoCommerce/maho that referenced this pull request Jan 14, 2025
@fballiano
OM PR 4468
bc7d357 
OpenMage/magento-lts#4468
@sreichel sreichel mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
chore Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Giftmessage Relates to Mage_Giftmessage Component: ImportExport Relates to Mage_ImportExport Component: Page Relates to Mage_Page Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: Shipping Relates to Mage_Shipping Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Weee Relates to Mage_Weee Component: Widget Relates to Mage_Widget Component: Wishlist Relates to Mage_Wishlist phpstan shell Relates to shell scripts Template : admin Relates to admin template Template : base Relates to base template Template : install Relates to install template Template : rwd Relates to rwd template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @kiatng @addison74