Fix fakenect not handling freenect_process_events_timeout #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no equivalent to freenect_process_events_timeout (core.c) in fakenect.c. The supplied fix might be crude, but it's better than fakenect not working at all. Signed-off-by: Jonas Deitmerg <jonasdeitmerg@aim.com>
|
I think this is OK because fakenect won't block inside |
piedar
added a commit
that referenced
this pull request
May 18, 2014
fakenect: Add implementation for freenect_process_events_timeout Reviewed-by: Benn Snyder <benn.snyder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used libfreenect for the first time and fakenect wouldn't work without this little fix. I know it's not elegant, but it does work. Playback is not very smooth, and I'm not sure if that has anything to do with the way this was fixed, so if someone got a minute, please have a look.