This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
a little cleanup and remove a line that would cause an exception #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbaynes
commented
Aug 24, 2017
| @@ -392,7 +400,6 @@ def connect_serial(serial_connection=None): | |||
| # Fix issue #328, sometimes serial_connection is None because of a | |||
| # serial port path / or error opening issue. | |||
| if serial_connection is None: | |||
| serial_connection.close() # Forces DTS on reconnect to reset Arduino | |||
There was a problem hiding this comment.
since serial_connection is None here, this line would have thrown an Exception.
sp4ghet
approved these changes
Aug 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New serial_close() function and some cleanup.
One exception causing line removed.
Extending @goruck 's awesome fixes.