Offer both 0 centered and positive hue -> float conversion #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@homu r+ |
|
📌 Commit 275a4ee has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jan 29, 2016
Offer both 0 centered and positive hue -> float conversion This is a compromise for the 0 centered vs all positive hue representation problem, where both alternatives are offered, but the current 0 centered behavior is kept as the default. The argument for this decision is that both variants are useful in different situations, and there is no obvious reason why one would be better than the other. The default is kept because it's consistent with how the trigonometric functions in `libstd` works. It's not the strongest reason, but it's as good as any. Changes in this PR: * Rename `to_float` to `to_degrees`. * Add `to_positive_degrees` and `to_positive_radians`. * Mention the ranges in the descriptions of the conversion functions. This is a breaking change, since it renames `to_float` to `to_degrees`. It closes #15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a compromise for the 0 centered vs all positive hue representation problem, where both alternatives are offered, but the current 0 centered behavior is kept as the default. The argument for this decision is that both variants are useful in different situations, and there is no obvious reason why one would be better than the other. The default is kept because it's consistent with how the trigonometric functions in
libstdworks. It's not the strongest reason, but it's as good as any.Changes in this PR:
to_floattoto_degrees.to_positive_degreesandto_positive_radians.This is a breaking change, since it renames
to_floattoto_degrees. It closes #15.