-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0x05a] Add APK Signature Scheme (v4) #1937
Conversation
@cpholguera Check this one too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending the PR @Saket-taneja. With this we stay up-to-date with the signature schemes ;) Please take a look at the suggestions. In the one about "v4" I put the focus more on "what we can tell about it that can be relevant to the tester, why was this introduced?" rather than on what can be anyway read on Android dev. docs (anyone interested e.g. on the crypto behind can open the links and keep reading). And to that I added the only thing I think it's relevant for testers for now which is the flag for the verification. What do you think?
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to give the basic understanding about the signature scheme to the security researchers as well as developers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the linting and we can merge ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Saket-taneja for the nice addition! Keep them coming 😊
@cpholguera This is again showing as rejected , can you check |
Hi @Saket-taneja I've already merged it so everything is fine. The "links check" it's not being very reliable so usually you can ignore it. We'll discuss internally how to deal with it. But for now you don't need to worry about it. For new PRs the most important check is the lint check. Bit as long as you use a markdown linter on your IDE you won't have issues with it. |
@cpholguera But in this case it is not mine , it is taking this from the LAST PR , I Haven't added this link/content maybe some other researcher |
@Saket-taneja don't worry, no one is to blame. As I explained the link check has issues on it's own. So please don't worry, everything is alright. We'll take care of that :) |
References - https://source.android.com/security/apksigning/v4
https://source.android.com/security/features/apk-verity
Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:
If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #< insert number here >.